-
Notifications
You must be signed in to change notification settings - Fork 909
Add experimental complete-blob-backfill flag #7751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
I have done some testing on this together with @michaelsproul To backfill the blobs beyond the 18-day window, we supply to the node that we want to backfill the following flags: Example: It is also recommended to supply the same flag to the source node (the node with the blobs data). Some caveats/known issues:
I believe this is expected as most of the peers do not have the blobs data outside the 18-day window. As the peers are penalized, this results in a fluctuating peer count, as evident from the connected peer below (note that the default peer is now 200 in the ![]()
Additional info: the node blobs data has backfilled to slot 10.2M from a fresh checkpoint sync:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me. Just need to disable the prune blobs behaviour when the flag is present.
Done. I opted to just override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Issue Addressed
A different (and complementary) approach for:
Proposed Changes
This PR adds a flag to set the DA boundary to the Deneb fork. The effect of this change is that Lighthouse will try to backfill all blobs.
Most peers do not have this data, but I'm thinking that combined with
trusted-peers
this could be quite effective.Additional Info
--prune-blobs false
when this flag is enabled, and override any setting of--prune-blobs true
.genesis-backfill
whenevercomplete-blob-backfill
is turned on? I'm inclined to say no, because users may want to backfill blobs only to e.g. 5 months (standard block backfill distance).